Re: Cleanup - Removed unused function parameter in reorder buffer & parallel vacuum - Mailing list pgsql-hackers

From Amit Kapila
Subject Re: Cleanup - Removed unused function parameter in reorder buffer & parallel vacuum
Date
Msg-id CAA4eK1KXKQc6J_X3qNVBtatfW3xP8H76uOWuD1MFBQw2djNPKw@mail.gmail.com
Whole thread Raw
In response to Re: Cleanup - Removed unused function parameter in reorder buffer & parallel vacuum  (Masahiko Sawada <masahiko.sawada@2ndquadrant.com>)
Responses Re: Cleanup - Removed unused function parameter in reorder buffer & parallel vacuum
List pgsql-hackers
On Fri, Jul 3, 2020 at 5:18 PM Masahiko Sawada
<masahiko.sawada@2ndquadrant.com> wrote:
>
> On Fri, 3 Jul 2020 at 17:07, vignesh C <vignesh21@gmail.com> wrote:
> >
> > Hi,
> >
> > While checking through the code I found that  some of the function
> > parameters in reorderbuffer & vacuumlazy are not used. I felt this
> > could be removed. I'm not sure if it is kept for future use or not.
> > Attached patch contains the changes for the same.
> > Thoughts?
> >
>
> For the part of parallel vacuum change, it looks good to me.
>

Unlike ReorderBuffer, this change looks fine to me as well.  This is a
quite recent (PG13) change and it would be good to remove it now.  So,
I will push this part of change unless I hear any objection in a day
or so.

-- 
With Regards,
Amit Kapila.
EnterpriseDB: http://www.enterprisedb.com



pgsql-hackers by date:

Previous
From: Fabien COELHO
Date:
Subject: Re: Missing "Up" navigation link between parts and doc root?
Next
From: Amit Kapila
Date:
Subject: Re: Default setting for enable_hashagg_disk (hash_mem)