Re: About adding a new filed to a struct in primnodes.h - Mailing list pgsql-hackers

From Andy Fan
Subject Re: About adding a new filed to a struct in primnodes.h
Date
Msg-id CAKU4AWrcBSJbr0jKC_+kv3=yjyuR1qapLa2ZbFS4-hOQiNiEgA@mail.gmail.com
Whole thread Raw
In response to Re: About adding a new filed to a struct in primnodes.h  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: About adding a new filed to a struct in primnodes.h  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers


On Wed, Nov 25, 2020 at 9:40 AM Tom Lane <tgl@sss.pgh.pa.us> wrote:
Andy Fan <zhihui.fan1213@gmail.com> writes:
> What I mean here is something like below.

What exactly would be the value of that?

There is work afoot, or at least on people's to-do lists, to mechanize
creation of the outfuncs/readfuncs/etc code directly from the Node
struct declarations.  So special cases for particular fields are going
to be looked on with great disfavor,

I agree with this, but I don't think there is no value in my suggestion
unless I missed something. Per my current understanding, the code
is too easy to make the datadir incompatible with binary, which requires
user to do some extra work and my suggestion is to avoid that and 
it is the value.  I think it is possible to make this strategy work with the 
"mechanize creation of the outfuncs/readfuncs/ect node",  but there is 
no point to try it unless we make agreement on if we should do that. 
 
even if you can make a case that
there's some reason to do it.  (Which I'm not seeing.  We've certainly
never had to do it in the past.)

                        regards, tom lane


--
Best Regards
Andy Fan

pgsql-hackers by date:

Previous
From: Tomas Vondra
Date:
Subject: Re: [PoC] Non-volatile WAL buffer
Next
From: Kyotaro Horiguchi
Date:
Subject: Re: Strange behavior with polygon and NaN