Postgres Pro
Downloads
Home   >   mailing lists

Re: WIP: Aggregation push-down - Mailing list pgsql-hackers

From Andy Fan
Subject Re: WIP: Aggregation push-down
Date
Msg-id CAKU4AWqK_X4L5WDsjnsFpm_Gt8Mx0+H4frC-6Pom1ro=aq44mQ@mail.gmail.com
Whole thread Raw
In response to Re: WIP: Aggregation push-down  (Antonin Houska <ah@cybertec.at>)
Responses Re: WIP: Aggregation push-down  (Andy Fan <zhihui.fan1213@gmail.com>)
Re: WIP: Aggregation push-down  (Antonin Houska <ah@cybertec.at>)
List pgsql-hackers
Tree view


On Thu, Feb 27, 2020 at 4:50 PM Antonin Houska <ah@cybertec.at> wrote:
legrand legrand <legrand_legrand@hotmail.com> wrote:

> Antonin Houska-2 wrote

> > Right now I recall two problems: 1) is the way I currently store
> > RelOptInfo for the grouped relations correct?, 2) how should we handle
> > types for which logical equality does not imply physical (byte-wise)
> > equality?
> >
> > Fortunately it seems now that I'm not the only one who cares about 2), so
> > this
> > problem might be resolved soon:
> >
> > https://www.postgresql.org/message-id/CAH2-Wzn3Ee49Gmxb7V1VJ3-AC8fWn-Fr8pfWQebHe8rYRxt5OQ%40mail.gmail.com
> >
> > But 1) still remains.
> >
>
> Hello
> would "pgsql: Add equalimage B-Tree support functions."
> https://www.postgresql.org/message-id/E1j72NY-0002gi-2B@gemulon.postgresql.org

Yes, it seems so. I'll adapt the patch soon, hopefully next week. Thanks for
reminder.

--
Antonin Houska
Web: https://www.cybertec-postgresql.com


Hi Antonin:

The more tests on your patch, the more powerful I feel it is! At the same time, 
I think the most difficult part to understand your design is you can accept
any number of generic join clauses,  so I guess more explanation on this part
may be helpful. 

At the code level, I did some slight changes on init_grouping_targets which may
make the code easier to read.  You are free to to use/not use it.

Hope your patch get more attention soon!

Best Regards
Andy Fan


Attachment

pgsql-hackers by date:

Previous
From: Michael Paquier
Date:
Subject: Re: forgotten initalization of a variable
Next
From: Kyotaro Horiguchi
Date:
Subject: Re: forgotten initalization of a variable