Re: Additional role attributes && superuser review - Mailing list pgsql-hackers

From Adam Brightwell
Subject Re: Additional role attributes && superuser review
Date
Msg-id CAKRt6CTgJdeGFqXevrp-DizaeHmg8gNVqu8n5T=ix3JAvpwwDQ@mail.gmail.com
Whole thread Raw
In response to Re: Additional role attributes && superuser review  (Adam Brightwell <adam.brightwell@crunchydatasolutions.com>)
Responses Re: Additional role attributes && superuser review  (Andrew Dunstan <andrew@dunslane.net>)
List pgsql-hackers
All,
 
Currently, I am using int32 simply because int64 is causing some issues.  The issue is that genbki.pl is not able to associate it with the int8 type as defined in pg_type.h.  Therefore Schema_pg_authid in schemapg.h isn't defined correctly.  I've been digging and scratching my head on this one but I have reached a point where I think it would be better just to ask.

Attached is a quite trivial patch that addresses the int64 (C) to int8 (SQL) mapping issue.

Further digging revealed that Catalog.pm wasn't accounting for int64 (thanks Stephen).  Would it be better to include this change as a separate patch (as attached) or would it be preferable to include with a larger role attribute bitmask patch?

Thanks,
Adam
Attachment

pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Use of recent Russian TZ changes in regression tests
Next
From: Peter Geoghegan
Date:
Subject: Re: GIN pageinspect functions