pg_upgrade: prep_status doesn't translate messages - Mailing list pgsql-hackers

From Kyotaro Horiguchi
Subject pg_upgrade: prep_status doesn't translate messages
Date
Msg-id CAKPRHzL7O6Jg4bai+c9BrA1e=fqHSmh6PKr1OPTiD_dx9HbpUg@mail.gmail.com
Whole thread Raw
Responses Re: pg_upgrade: prep_status doesn't translate messages
List pgsql-hackers
Hello.

In pg_upgrade, prep statuts is shown in English even if LANG is
set to other languages.

$ LANG=ja_JP.UTF8 pg_upgrade ...
<"Performing Consistency Checks on Old Live Server" in Japanese>
--------------------------------------------------
Checking cluster versions                                   ok
Checking database user is the install user                  ok
Checking database connection settings                       ok
Checking for prepared transactions                          ok
...
<"*Clusters are compatible*" in Japanese>


prep_status is marked as GETTEXT_TRIGGERS but actually doesn't
translate. I suppose the reason is we don't have a general and
portable means to align the message strings containing non-ascii
characters.

I'd like to propose to append " ... " instead of aligning messages.

Checking cluster versions ... ok
Checking database user is the install user ... ok
Checking database connection settings ... ok
Checking for prepared transactions ... ok

If we don't do that, translation lines in po files are
useless. prep_stauts must be removed from TETTEXT_TRIGGERS, and a
comment that explains the reason for not translating.

Any opinions?

regardes.


-- 
Kyotaro Horiguchi
NTT Open Source Software Center

Attachment

pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: [PATCH] Fix potential memoryleak in guc.c
Next
From: Noah Misch
Date:
Subject: Fix testing on msys when builddir is under /c mount point