Fix testing on msys when builddir is under /c mount point - Mailing list pgsql-hackers

From Noah Misch
Subject Fix testing on msys when builddir is under /c mount point
Date
Msg-id 20190610045838.GA238501@rfd.leadboat.com
Whole thread Raw
Responses Re: Fix testing on msys when builddir is under /c mount point
List pgsql-hackers
Several TAP test suites have a need to translate from an msys path to a
Windows path.  They currently use two ways to do that:

1. TestLib::real_dir, new in v11, is sound but works for directories only.
2. The $vfs_path approach is semi-private to PostgresNode.pm and 017_shm.pl,
   and it does not work if the file falls in a mount point other than "/".
   For example, it has been doing the wrong thing when builddir is
   /c/nm/postgresql (falling in mount point /c).

I'd like to fix the mount point problem and consolidate these two methods.  I
plan to call it TestLib::perl2host, since it translates a path in Perl's
notion of the filesystem to a path in the @host@ notion of the filesystem.
Attached.

Attachment

pgsql-hackers by date:

Previous
From: Kyotaro Horiguchi
Date:
Subject: pg_upgrade: prep_status doesn't translate messages
Next
From: Amit Khandekar
Date:
Subject: Re: Minimal logical decoding on standbys