Postgres Pro
Downloads
Home   >   mailing lists

[pgadmin-hackers] PATCH: Dialogue control buttons should be consistent (pgAdmin4) - Mailing list pgadmin-hackers

From Murtuza Zabuawala
Subject [pgadmin-hackers] PATCH: Dialogue control buttons should be consistent (pgAdmin4)
Date
Msg-id CAKKotZTSSsps_Zb033pSHg+v_3rvtUunoAZtCWVDnze+uiUv0w@mail.gmail.com
Whole thread Raw
Responses Re: [pgadmin-hackers] PATCH: Dialogue control buttons should beconsistent (pgAdmin4)  (Dave Page <dpage@pgadmin.org>)
List pgadmin-hackers
Tree view
Hi,

PFA patch to fix the issue where  some dialogue control buttons were not consistent with others dialogs.
RM#1364

Patch fixes,
1) Preferences: Close, Maximise, Pin 
- Removed Pin button

2) Wizards: Close 
- Added Maximise button, which is can used with 'show_header_maximize_btn' option.

3) Properties: Close
- N/A, As this is custom wcDocker panel not alertify dialog.

4) User manager: Maximise 
- We can't have close button in User Manager as data validation was main requirement, If user clicks on right top close button while having dirty data in dialog then we can't stop alertify dialog from closing even with confirm prompt hence we have removed the button.


--
Regards,
Murtuza Zabuawala
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
Attachment

pgadmin-hackers by date:

Previous
From: Neel Patel
Date:
Subject: Re: [pgadmin-hackers] [pgAdmin4]: RM-1910 - Remember last useddirectory in the file manager
Next
From: Dave Page
Date:
Subject: [pgadmin-hackers] pgAdmin 4 commit: Format JSON more efficiently. This cansignificantly