Postgres Pro
Downloads
Home   >   mailing lists

Re: [pgAdmin4][RM#3235] Code refactoring in Query tool - Mailing list pgadmin-hackers

From Murtuza Zabuawala
Subject Re: [pgAdmin4][RM#3235] Code refactoring in Query tool
Date
Msg-id CAKKotZRwxcozrSic25xSCtK_z7bdnksrF2_4GSeWi=6zDUSw_g@mail.gmail.com
Whole thread Raw
In response to Re: [pgAdmin4][RM#3235] Code refactoring in Query tool  (Dave Page <dpage@pgadmin.org>)
Responses Re: [pgAdmin4][RM#3235] Code refactoring in Query tool
List pgadmin-hackers
Tree view
Hi Dave,

PFA updated patch, I've renamed it to query_tool_http_error_handler.js & query_tool_http_error_handler_spec.js respectively. 

--
Regards,
Murtuza Zabuawala
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


On Tue, Apr 3, 2018 at 7:43 PM, Dave Page <dpage@pgadmin.org> wrote:
HI

On Tue, Apr 3, 2018 at 12:27 PM, Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote:
Hi,

PFA patch to extract the common code from query tool to handle ajax errors & connection handling, Also added unit tests around extracted code. 

Looks good to me, except, I wonder if we should rename is_new_transaction_required.js/is_new_transaction_required_spec.js to something a little more generic; maybe conn_tx_handler_funcs.js? Not sure I like that though.


--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

Attachment

pgadmin-hackers by date:

Previous
From: Dave Page
Date:
Subject: Re: [pgAdmin4][RM#3155] Allow user to lock the Layout
Next
From: Murtuza Zabuawala
Date:
Subject: Re: [pgAdmin4][RM#3154] Update modules to latest version