Postgres Pro
Downloads
Home   >   mailing lists

Re: [pgAdmin4][RM#3235] Code refactoring in Query tool - Mailing list pgadmin-hackers

From Dave Page
Subject Re: [pgAdmin4][RM#3235] Code refactoring in Query tool
Date
Msg-id CA+OCxoygT-+xezSAboURa9E9myQCX2GbO4DCFg7yY+umHhEa5g@mail.gmail.com
Whole thread Raw
In response to [pgAdmin4][RM#3235] Code refactoring in Query tool  (Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com>)
Responses Re: [pgAdmin4][RM#3235] Code refactoring in Query tool
List pgadmin-hackers
Tree view
HI

On Tue, Apr 3, 2018 at 12:27 PM, Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote:
Hi,

PFA patch to extract the common code from query tool to handle ajax errors & connection handling, Also added unit tests around extracted code. 

Looks good to me, except, I wonder if we should rename is_new_transaction_required.js/is_new_transaction_required_spec.js to something a little more generic; maybe conn_tx_handler_funcs.js? Not sure I like that though.


--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

pgadmin-hackers by date:

Previous
From: Dave Page
Date:
Subject: Re: [pgAdmin4][Patch]: RM #1978 - Add an option to allow user todisable alertifyjs and acitree animations
Next
From: Murtuza Zabuawala
Date:
Subject: Re: [pgAdmin4][RM#3154] Update modules to latest version