Re: [PATCH] Tables node (pgAdmin4) - Mailing list pgadmin-hackers

From Murtuza Zabuawala
Subject Re: [PATCH] Tables node (pgAdmin4)
Date
Msg-id CAKKotZRPpB=F769GOsbHYPawo1k8a59Et4L-hD_F4rVtwub-2A@mail.gmail.com
Whole thread Raw
In response to Re: [PATCH] Tables node (pgAdmin4)  (Thom Brown <thom@linux.com>)
Responses Re: [PATCH] Tables node (pgAdmin4)  (Ashesh Vashi <ashesh.vashi@enterprisedb.com>)
List pgadmin-hackers
Hi,

PFA updated patch which will also include new query given by Thom for "Of type" drop-down.


Regards,
Murtuza


--
Regards,
Murtuza Zabuawala
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


On Thu, May 26, 2016 at 4:04 PM, Thom Brown <thom@linux.com> wrote:
On 26 May 2016 at 11:20, Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote:
Hi,

PFA patch for RM#1231 & RM#1237.

Additionally I have shifted 'Advanced tab' after columns & constraint tab.


@Thom,

Reading "Of type" drop-down, We borrowed sql query from pgadmin3 to populate "Of type" combo box as given below.
I was not able to find a way to differentiate between table & composite type populating from below given query,  
I'll put in todo list, may be someone from community can help in future. 

SELECT t.oid,
  quote_ident(n.nspname)||'.'||quote_ident(t.typname) AS typname
  FROM pg_type t, pg_namespace n
WHERE t.typtype='c' AND t.typnamespace=n.oid
  AND NOT (n.nspname like 'pg_%' OR n.nspname='information_schema')
ORDER BY typname;


This should work:

SELECT c.oid,
  quote_ident(n.nspname)||'.'||quote_ident(c.relname) AS typname
  FROM pg_namespace n, pg_class c
WHERE c.relkind = 'c' AND c.relnamespace=n.oid
  AND NOT (n.nspname like 'pg_%' OR n.nspname='information_schema')
ORDER BY typname;

Although, to avoid confusion, the "typname" alias should probably just be "relname".
 
Thom

Attachment

pgadmin-hackers by date:

Previous
From: Thom Brown
Date:
Subject: Re: [PATCH] Tables node (pgAdmin4)
Next
From: Dave Page
Date:
Subject: Re: Documentation patch for pgAdmin 4