Re: pgAdmin4 form control error icon position change - Mailing list pgadmin-hackers

From Murtuza Zabuawala
Subject Re: pgAdmin4 form control error icon position change
Date
Msg-id CAKKotZQtVVDGY__Nf5y7sX6O1Kb99gxyReWJGZwqNv29igBpew@mail.gmail.com
Whole thread Raw
In response to pgAdmin4 form control error icon position change  (Aditya Toshniwal <aditya.toshniwal@enterprisedb.com>)
Responses Re: pgAdmin4 form control error icon position change
List pgadmin-hackers
Hello Aditya,

Could you please create new RM for the issue, so that we can keep track of changes, It will be difficult for us to keep track of email for the details.

--
Regards,
Murtuza Zabuawala
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


On Wed, Mar 21, 2018 at 2:28 PM, Aditya Toshniwal <aditya.toshniwal@enterprisedb.com> wrote:

Hi Team,

This is regarding the position of error icon of a pgAdmin form control. Below are the screenshots. As we can see, the error icon is overlapping the control buttons like the drop down button, spinner up down buttons, etc.




We propose that we can move the error icon to the front of the label of the form control. Below are screenshots.




Attached is the patch for the above changes. 
Kindly review.
--
Thanks and Regards,
Aditya Toshniwal
Software Engineer | EnterpriseDB Software Solutions
Pune | Mob - 8055837949

Attachment

pgadmin-hackers by date:

Previous
From: pgAdmin 4 Jenkins
Date:
Subject: Jenkins build is back to normal : pgadmin4-master-python26 #671
Next
From: Aditya Toshniwal
Date:
Subject: Re: pgAdmin4 form control error icon position change