Re: bug in citext's upgrade script for parallel aggregates - Mailing list pgsql-hackers

From David Rowley
Subject Re: bug in citext's upgrade script for parallel aggregates
Date
Msg-id CAKJS1f_mnyERTn2uAONOFWeerKX7Z4jXcYxba=UhUQEwfE5NXQ@mail.gmail.com
Whole thread Raw
In response to Re: bug in citext's upgrade script for parallel aggregates  (Robert Haas <robertmhaas@gmail.com>)
Responses Re: bug in citext's upgrade script for parallel aggregates  (Andreas Karlsson <andreas@proxel.se>)
List pgsql-hackers
On 30 June 2016 at 03:49, Robert Haas <robertmhaas@gmail.com> wrote:
> On Sat, Jun 25, 2016 at 3:44 AM, Andreas Karlsson <andreas@proxel.se> wrote:
>> On 06/24/2016 01:31 PM, David Rowley wrote:
>>> Seems there's a small error in the upgrade script for citext for 1.1
>>> to 1.2 which will cause min(citext) not to be parallel enabled.
>>>
>>> max(citext)'s combinefunc is first set incorrectly, but then updated
>>> to the correct value. I assume it was meant to set the combine
>>> function for min(citext) instead.
>>>
>>> Fix attached. I've assumed that because we're still in beta that we
>>> can get away with this fix rather than making a 1.3 version to fix the
>>> issue.
>>
>> Yes, this is indeed a bug.
>
> Since we've already released beta2, I think we need to do a whole new
> extension version.  We treated beta1 as a sufficiently-significant
> event to mandate a version bump, so we should do the same here.

Ok, good point. Patch attached.




--
 David Rowley                   http://www.2ndQuadrant.com/
 PostgreSQL Development, 24x7 Support, Training & Services

Attachment

pgsql-hackers by date:

Previous
From: Noah Misch
Date:
Subject: Re: dumping database privileges broken in 9.6
Next
From: Stephen Frost
Date:
Subject: Re: dumping database privileges broken in 9.6