Re: bug in citext's upgrade script for parallel aggregates - Mailing list pgsql-hackers

From Robert Haas
Subject Re: bug in citext's upgrade script for parallel aggregates
Date
Msg-id CA+Tgmoan4qgnj03-xpzPoSKh8AMbmF-sT5Vv7f-MCGt4yThBNA@mail.gmail.com
Whole thread Raw
In response to Re: bug in citext's upgrade script for parallel aggregates  (Andreas Karlsson <andreas@proxel.se>)
Responses Re: bug in citext's upgrade script for parallel aggregates  (David Rowley <david.rowley@2ndquadrant.com>)
List pgsql-hackers
On Sat, Jun 25, 2016 at 3:44 AM, Andreas Karlsson <andreas@proxel.se> wrote:
> On 06/24/2016 01:31 PM, David Rowley wrote:
>> Seems there's a small error in the upgrade script for citext for 1.1
>> to 1.2 which will cause min(citext) not to be parallel enabled.
>>
>> max(citext)'s combinefunc is first set incorrectly, but then updated
>> to the correct value. I assume it was meant to set the combine
>> function for min(citext) instead.
>>
>> Fix attached. I've assumed that because we're still in beta that we
>> can get away with this fix rather than making a 1.3 version to fix the
>> issue.
>
> Yes, this is indeed a bug.

Since we've already released beta2, I think we need to do a whole new
extension version.  We treated beta1 as a sufficiently-significant
event to mandate a version bump, so we should do the same here.

-- 
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company



pgsql-hackers by date:

Previous
From: Jeff Janes
Date:
Subject: Re: pgbench unable to scale beyond 100 concurrent connections
Next
From: Stephen Frost
Date:
Subject: Re: dumping database privileges broken in 9.6