On 16 November 2017 at 15:52, Tom Lane <
tgl@sss.pgh.pa.us> wrote:
> Anybody want to test this manually, or shall we just throw it into the
> buildfarm and see what blows up?
I don't have any cygwin around, but it compiles fine with the Visual Studios 2012 toolchain.
I do get some warnings:
(ClCompile target) ->
src/test/modules/test_session_hooks/test_session_hooks.c(112): warning C4113: 'void (__cdecl *)()' differs in parameter lists from 'session_start_hook_type' [test_session_hooks.vcxproj]
src/test/modules/test_session_hooks/test_session_hooks.c(113): warning C4113: 'void (__cdecl *)()' differs in parameter lists from 'session_end_hook_type' [test_session_hooks.vcxproj].
2 Warning(s)
But I imagine that was caused by 745948422c (also get the warnings without your patch)
--
David Rowley
http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training & Services
