Re: Tighten up a few overly lax regexes in pg_dump's tap tests - Mailing list pgsql-hackers

From David Rowley
Subject Re: Tighten up a few overly lax regexes in pg_dump's tap tests
Date
Msg-id CAKJS1f_7nqRYE+vTtRjEwy2WZBkKo=PmfjTxT3+Q=Jb0f24sbg@mail.gmail.com
Whole thread Raw
In response to Re: Tighten up a few overly lax regexes in pg_dump's tap tests  (Michael Paquier <michael@paquier.xyz>)
Responses Re: Tighten up a few overly lax regexes in pg_dump's tap tests  (Michael Paquier <michael@paquier.xyz>)
List pgsql-hackers
On Tue, 5 Feb 2019 at 14:41, Michael Paquier <michael@paquier.xyz> wrote:
>  Instead of the approach you are
> proposing, perhaps it would make sense to extend this way of doing
> things then?  For example some tests with CREATE CONVERSION do so.  It
> looks much more portable than having to escape every dot.

I'm not particularly excited either way, but here's a patch with it that way.

I did leave a couple untouched as there was quite a bit of escaping
going on already. I didn't think switching between \Q and \E would
have made those ones any more pleasing to the eye.

-- 
 David Rowley                   http://www.2ndQuadrant.com/
 PostgreSQL Development, 24x7 Support, Training & Services

Attachment

pgsql-hackers by date:

Previous
From: David Rowley
Date:
Subject: Re: Inadequate executor locking of indexes
Next
From: David Rowley
Date:
Subject: Re: Tighten up a few overly lax regexes in pg_dump's tap tests