Re: Tighten up a few overly lax regexes in pg_dump's tap tests - Mailing list pgsql-hackers

From Michael Paquier
Subject Re: Tighten up a few overly lax regexes in pg_dump's tap tests
Date
Msg-id 20190205072618.GF1882@paquier.xyz
Whole thread Raw
In response to Re: Tighten up a few overly lax regexes in pg_dump's tap tests  (David Rowley <david.rowley@2ndquadrant.com>)
Responses Re: Tighten up a few overly lax regexes in pg_dump's tap tests
List pgsql-hackers
On Tue, Feb 05, 2019 at 05:46:55PM +1300, David Rowley wrote:
> I did leave a couple untouched as there was quite a bit of escaping
> going on already. I didn't think switching between \Q and \E would
> have made those ones any more pleasing to the eye.

-    qr/^ALTER TABLE dump_test.test_table ENABLE ROW LEVEL SECURITY;/m,
+    qr/^\QALTER TABLE dump_test.test_table ENABLE ROW LEVEL SECURITY;/m,
I would have just appended the \E for consistency at the end of the
strings.  Except that it looks fine.  No need to send an updated
version, it seems that you have all the spots.  I'll do an extra pass
on it tomorrow and see if I can commit it.
--
Michael

Attachment

pgsql-hackers by date:

Previous
From: Haribabu Kommi
Date:
Subject: Re: Memory contexts reset for trigger invocations
Next
From: David Rowley
Date:
Subject: Documentation and code don't agree about partitioned table UPDATEs