Re: [HACKERS] Removing [Merge]Append nodes which contain a single subpath - Mailing list pgsql-hackers

From David Rowley
Subject Re: [HACKERS] Removing [Merge]Append nodes which contain a single subpath
Date
Msg-id CAKJS1f8n09ELtR3FC4JfcX20V-jT2NVw7huZuE-0UyyUEaY2Sw@mail.gmail.com
Whole thread Raw
In response to Re: [HACKERS] Removing [Merge]Append nodes which contain a single subpath  (David Rowley <david.rowley@2ndquadrant.com>)
Responses Re: [HACKERS] Removing [Merge]Append nodes which contain a single subpath  (Ashutosh Bapat <ashutosh.bapat@enterprisedb.com>)
Re: [HACKERS] Removing [Merge]Append nodes which contain a single subpath  (David Rowley <david.rowley@2ndquadrant.com>)
List pgsql-hackers
On 30 November 2017 at 16:04, David Rowley <david.rowley@2ndquadrant.com> wrote:
> I've attached a patch which fixes the conflict with the regression test
> expected output in inherits.out. I've also made changes to the expected
> output in the new partition_prune test's expected output.

I've attached an updated patch which fixes the conflicts caused by ab727167.

Also, I've attached a patch which is not intended for commit which
shows the subtle differences between directly querying a partitioned
table with a single remaining leaf partition to scan vs directly
querying the leaf partition itself. The regression test failures seen
with both patches applied highlight the differences.

While rebasing this today I also noticed that we won't properly detect
unique joins in add_paths_to_joinrel() as we're still testing for
uniqueness against the partitioned parent rather than the only child.
This is likely not a huge problem since we'll always get a false
negative and never a false positive, but it is a missing optimisation.
I've not thought of how to solve it yet, it's perhaps not worth going
to too much trouble over.

-- 
 David Rowley                   http://www.2ndQuadrant.com/
 PostgreSQL Development, 24x7 Support, Training & Services

Attachment

pgsql-hackers by date:

Previous
From: Merlin Moncure
Date:
Subject: Re: [HACKERS] Transaction control in procedures
Next
From: Thomas Munro
Date:
Subject: Re: es_query_dsa is broken