Re: Some incorrect comments and out-dated README from run-time pruning - Mailing list pgsql-hackers

From David Rowley
Subject Re: Some incorrect comments and out-dated README from run-time pruning
Date
Msg-id CAKJS1f-uJ4AOC=BhHjPPi2YPFDF5YXinfdbLSQze_CS48+pROQ@mail.gmail.com
Whole thread Raw
In response to Re: Some incorrect comments and out-dated README from run-timepruning  (Peter Eisentraut <peter.eisentraut@2ndquadrant.com>)
Responses Re: Some incorrect comments and out-dated README from run-timepruning  (Peter Eisentraut <peter.eisentraut@2ndquadrant.com>)
List pgsql-hackers
On 10 October 2018 at 02:38, Peter Eisentraut
<peter.eisentraut@2ndquadrant.com> wrote:
> - * subplan_map[] and subpart_map[] are indexed by partition index (where
> - * zero is the topmost partition, and non-leaf partitions must come before
> - * their children).  For a leaf partition p, subplan_map[p] contains the
> + * subplan_map[] and subpart_map[] are indexed by partition index (as
> defined
> + * in the PartitionDesc).  For a leaf partition p, subplan_map[p]
> contains the
>
> I don't see what someone reading this comment would do with "as defined
> in the PartitionDesc".  I don't see any PartitionDesc referenced or
> mentioned at or near that struct.

Perhaps it should have mentioned: the PartitionDesc belonging to the
partitioned table referenced by 'rtindex'.

I've attached another version.

-- 
 David Rowley                   http://www.2ndQuadrant.com/
 PostgreSQL Development, 24x7 Support, Training & Services

Attachment

pgsql-hackers by date:

Previous
From: Thomas Munro
Date:
Subject: Re: [HACKERS] Why does logical replication launcher exit with exitcode 1?
Next
From: Daniel Gustafsson
Date:
Subject: Re: Support custom socket directory in pg_upgrade