Re: Some incorrect comments and out-dated README from run-timepruning - Mailing list pgsql-hackers

From Peter Eisentraut
Subject Re: Some incorrect comments and out-dated README from run-timepruning
Date
Msg-id 2a1a4b45-dab5-433e-c2dc-d4e9abd51afb@2ndquadrant.com
Whole thread Raw
In response to Re: Some incorrect comments and out-dated README from run-time pruning  (David Rowley <david.rowley@2ndquadrant.com>)
List pgsql-hackers
On 09/10/2018 22:25, David Rowley wrote:
> On 10 October 2018 at 02:38, Peter Eisentraut
> <peter.eisentraut@2ndquadrant.com> wrote:
>> - * subplan_map[] and subpart_map[] are indexed by partition index (where
>> - * zero is the topmost partition, and non-leaf partitions must come before
>> - * their children).  For a leaf partition p, subplan_map[p] contains the
>> + * subplan_map[] and subpart_map[] are indexed by partition index (as
>> defined
>> + * in the PartitionDesc).  For a leaf partition p, subplan_map[p]
>> contains the
>>
>> I don't see what someone reading this comment would do with "as defined
>> in the PartitionDesc".  I don't see any PartitionDesc referenced or
>> mentioned at or near that struct.
> 
> Perhaps it should have mentioned: the PartitionDesc belonging to the
> partitioned table referenced by 'rtindex'.
> 
> I've attached another version.

Committed and backpatched to PG11.

-- 
Peter Eisentraut              http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services


pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: Pull up sublink of type 'NOT NOT (expr)'
Next
From: Dmitry Dolgov
Date:
Subject: Re: Range phrase operator in tsquery