On 09/10/2018 22:25, David Rowley wrote:
> On 10 October 2018 at 02:38, Peter Eisentraut
> <peter.eisentraut@2ndquadrant.com> wrote:
>> - * subplan_map[] and subpart_map[] are indexed by partition index (where
>> - * zero is the topmost partition, and non-leaf partitions must come before
>> - * their children). For a leaf partition p, subplan_map[p] contains the
>> + * subplan_map[] and subpart_map[] are indexed by partition index (as
>> defined
>> + * in the PartitionDesc). For a leaf partition p, subplan_map[p]
>> contains the
>>
>> I don't see what someone reading this comment would do with "as defined
>> in the PartitionDesc". I don't see any PartitionDesc referenced or
>> mentioned at or near that struct.
>
> Perhaps it should have mentioned: the PartitionDesc belonging to the
> partitioned table referenced by 'rtindex'.
>
> I've attached another version.
Committed and backpatched to PG11.
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services