Postgres Pro
Downloads
Home   >   mailing lists

Re: Some memory allocations in gin fastupdate code are a bit brain dead - Mailing list pgsql-hackers

From David Rowley
Subject Re: Some memory allocations in gin fastupdate code are a bit brain dead
Date
Msg-id CAKJS1f-drmq7rPcF-NMgGMxbGtBZPsZeJ=SEFLHXyJqmViqW+A@mail.gmail.com
Whole thread Raw
In response to Re: Some memory allocations in gin fastupdate code are a bit brain dead  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
Tree view 
On Thu, 20 Dec 2018 at 05:44, Tom Lane <tgl@sss.pgh.pa.us> wrote:
> I don't think this is quite bulletproof against overflow, especially
> in view of the rather careless mixing of int32 and uint32 variables
> that exists here.  The easiest way to make it bulletproof is to add
> an explicit test, so I did that and pushed it.

Thanks for tidying that up and for pushing.


-- 
 David Rowley                   http://www.2ndQuadrant.com/
 PostgreSQL Development, 24x7 Support, Training & Services

pgsql-hackers by date:

Previous
From: David Rowley
Date:
Subject: Re: Ordered Partitioned Table Scans
Next
From: Robert Haas
Date:
Subject: Re: Why are we PageInit'ing buffers in RelationAddExtraBlocks()?