Re: Terminate the idle sessions - Mailing list pgsql-hackers

From David G. Johnston
Subject Re: Terminate the idle sessions
Date
Msg-id CAKFQuwaRyr3jOfOTpaiPHYMcXPQkB3enXgP88FRg0jFH_2J_SA@mail.gmail.com
Whole thread Raw
In response to Re: Terminate the idle sessions  (Li Japin <japinli@hotmail.com>)
Responses Re: Terminate the idle sessions
List pgsql-hackers
On Mon, Nov 16, 2020 at 5:41 AM Li Japin <japinli@hotmail.com> wrote:
Thanks for your review! Attached.

Reading the doc changes:

I'd rather not name postgres_fdw explicitly, or at least not solely, as a reason for setting this to zero.  Additionally, using postgres_fdw within the server doesn't cause issues, its using postgres_fdw and the remote server having this setting set to zero that causes a problem.

<note>
Consider setting this for specific users instead of as a server default.  Client connections managed by connection poolers, or initiated indirectly like those by a remote postgres_fdw using server, should probably be excluded from this timeout.

Text within <para> should be indented one space (you missed both under listitem).

I'd suggest a comment that aside from a bit of resource consumption idle sessions do not interfere with the long-running stability of the server, unlike idle-in-transaction sessions which are controlled by the other configuration setting.

David J.

pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: [PATCH] Covering SPGiST index
Next
From: Alvaro Herrera
Date:
Subject: Re: remove spurious CREATE INDEX CONCURRENTLY wait