Re: slru bank - Mailing list pgsql-hackers

From David G. Johnston
Subject Re: slru bank
Date
Msg-id CAKFQuwa3M9U6iZ_TYKmVxj-nB5ovRFOwWybACcFrQxNqPCPx4g@mail.gmail.com
Whole thread Raw
In response to Re: slru bank  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
On Thu, Aug 22, 2024 at 7:27 PM Tom Lane <tgl@sss.pgh.pa.us> wrote:
"David G. Johnston" <david.g.johnston@gmail.com> writes:
> On Thu, Aug 22, 2024 at 7:07 PM 席冲(宜穆) <xichong.xc@alibaba-inc.com> wrote:
>> In SlruSelectLRUPage(),  Why do we need to traverse all slots to find that
>> a page already has a buffer assigned? Why not find it
>> from the [bankstart,bankend]?

> Only the bank is searched, both of the logic loops are bounded by:
> for (int slotno = bankstart; slotno < bankend; slotno++)

I think the OP has rediscovered the bug already fixed in 7b063ff26.
That's post-17beta2, though.


Indeed.  I was looking at HEAD.

David J.

pgsql-hackers by date:

Previous
From: Richard Guo
Date:
Subject: Re: Redundant Result node
Next
From: Tender Wang
Date:
Subject: Re: [BUG] Fix DETACH with FK pointing to a partitioned table fails