Re: slru bank - Mailing list pgsql-hackers

From Tom Lane
Subject Re: slru bank
Date
Msg-id 2116449.1724380062@sss.pgh.pa.us
Whole thread Raw
In response to Re: slru bank  ("David G. Johnston" <david.g.johnston@gmail.com>)
Responses Re: slru bank
List pgsql-hackers
"David G. Johnston" <david.g.johnston@gmail.com> writes:
> On Thu, Aug 22, 2024 at 7:07 PM 席冲(宜穆) <xichong.xc@alibaba-inc.com> wrote:
>> In SlruSelectLRUPage(),  Why do we need to traverse all slots to find that
>> a page already has a buffer assigned? Why not find it
>> from the [bankstart,bankend]?

> Only the bank is searched, both of the logic loops are bounded by:
> for (int slotno = bankstart; slotno < bankend; slotno++)

I think the OP has rediscovered the bug already fixed in 7b063ff26.
That's post-17beta2, though.

            regards, tom lane



pgsql-hackers by date:

Previous
From: "David G. Johnston"
Date:
Subject: Re: slru bank
Next
From: Richard Guo
Date:
Subject: Re: Redundant Result node