Re: Typo in the Section "3.6. Inheritance" - Mailing list pgsql-docs

From David G. Johnston
Subject Re: Typo in the Section "3.6. Inheritance"
Date
Msg-id CAKFQuwYPV+Aw9JjbO5CX-8D5AFbZkwH9zuWpSt53JEEWBi3_Ew@mail.gmail.com
Whole thread Raw
In response to Re: Typo in the Section "3.6. Inheritance"  (Bruce Momjian <bruce@momjian.us>)
Responses Re: Typo in the Section "3.6. Inheritance"
List pgsql-docs
On Fri, Aug 21, 2020 at 4:36 PM Bruce Momjian <bruce@momjian.us> wrote:
On Wed, Aug  5, 2020 at 11:29:31PM -0700, David G. Johnston wrote:

> Removing "char" from the tutorial is a nice side-effect that we probably want
> to do even if we keep "state".

I think CHAR(2) is fine because it is always 2 characters.

You imply "it is always two non-blank characters" though that isn't what CHAR(2) means.  Adding CHECK (state ~ '^[A-Z]{2}$') and leaving the type as text would be best from a pure model perspective - but this isn't the place to teach that and for the same reason char(2) isn't terrible.

How is the attached patch, based on your suggestions?

Works for me.

David J.

pgsql-docs by date:

Previous
From: Michael Paquier
Date:
Subject: Re: Typo in the Section "3.6. Inheritance"
Next
From: "David G. Johnston"
Date:
Subject: Re: Subscript expressions do not have to evaluate to integers