On Fri, Aug 21, 2020 at 07:09:31PM -0700, David G. Johnston wrote:
> On Fri, Aug 21, 2020 at 4:36 PM Bruce Momjian <bruce@momjian.us> wrote:
>
> On Wed, Aug 5, 2020 at 11:29:31PM -0700, David G. Johnston wrote:
>
> > Removing "char" from the tutorial is a nice side-effect that we probably
> want
> > to do even if we keep "state".
>
> I think CHAR(2) is fine because it is always 2 characters.
>
>
> You imply "it is always two non-blank characters" though that isn't what CHAR
> (2) means. Adding CHECK (state ~ '^[A-Z]{2}$') and leaving the type as text
> would be best from a pure model perspective - but this isn't the place to teach
> that and for the same reason char(2) isn't terrible.
>
>
> How is the attached patch, based on your suggestions?
>
>
> Works for me.
Patch applied back through 9.5.
--
Bruce Momjian <bruce@momjian.us> https://momjian.us
EnterpriseDB https://enterprisedb.com
The usefulness of a cup is in its emptiness, Bruce Lee
