Re: Fixes for missing schema qualifications - Mailing list pgsql-hackers

From David G. Johnston
Subject Re: Fixes for missing schema qualifications
Date
Msg-id CAKFQuwYGXhD7ngZ-xJHg+GR8Avn5nPhcv7g_yWxD8fLH+DqNhw@mail.gmail.com
Whole thread Raw
In response to Re: Fixes for missing schema qualifications  (Tatsuo Ishii <ishii@sraoss.co.jp>)
Responses Re: Fixes for missing schema qualifications  (Tatsuo Ishii <ishii@sraoss.co.jp>)
Re: Fixes for missing schema qualifications  (Michael Paquier <michael@paquier.xyz>)
List pgsql-hackers
On Tue, Mar 13, 2018 at 5:11 PM, Tatsuo Ishii <ishii@sraoss.co.jp> wrote:
>>> +                                    "select pg_catalog.count(*) "
>>> +                                    "from pg_catalog.pg_namespace where nspname = '%s'",
>>
>> This qualifies some functions, but it leaves plenty of unqualified operators.

Oops. I meant:

select pg_catalog.count(*) from pg_catalog.pg_namespace where pg_catalog.nameeq(nspname, '%s');


​I'd rather write that:

select [...] where nspname operator(pg_catalog.=) '%s'​

Introducing undocumented implementation functions to these queries is undesirable; and besides, indexing and equivalence relies on operators and not the underlying functions so there would be some risk of performance issues if the functions were used directly.

David J.

pgsql-hackers by date:

Previous
From: Tatsuo Ishii
Date:
Subject: Re: Fixes for missing schema qualifications
Next
From: David Rowley
Date:
Subject: Re: [HACKERS] Removing [Merge]Append nodes which contain a single subpath