Further comments welcome so I'm putting it back into needs review for the moment while I work on the refactor.
attached fixed patch
all tests passed
doc build without problems
Thanks.
Actually, one question I didn't pose before, does the SQL standard define DROP TYPE to target domains while also providing for a DROP DOMAIN command? Do drop commands for the other types we have not exist because those aren't SQL standard types (or the standard they are standard types but the commands aren't defined)?
It looks like Postgres user defined types are something else than ANSI SQL - so CREATE TYPE and DROP TYPE did different work.
In the section DROP TYPE in ANSI SQL there is not mentioned any relation to domains.
Attaching a backpatch-able patch for the main docs and tests, v4
Added a head-only patch for the glossary changes, set to v4 as well.
I didn't try and address any SQL standard dynamics here.
