Re: Possibly hard-to-read message - Mailing list pgsql-hackers

From David G. Johnston
Subject Re: Possibly hard-to-read message
Date
Msg-id CAKFQuwYDZEmRnmSUUQSi=vX7MiKXb3Z-4eyAB1RqqmtWxJ0DTA@mail.gmail.com
Whole thread Raw
In response to Re: Possibly hard-to-read message  (Daniel Gustafsson <daniel@yesql.se>)
Responses Re: Possibly hard-to-read message
List pgsql-hackers
On Sun, Apr 6, 2025 at 2:52 PM Daniel Gustafsson <daniel@yesql.se> wrote:

Looking at the other variables they tend to use "if set, then" so we should
probably stick to that for this as well?  Something like the below perhaps?

        HELP0("  WATCH_INTERVAL\n"
-                 "    number of seconds \\watch by default waits between executing the query buffer\n");
+                 "    if set to an interval value, overrides the default two second \\watch interval\n");


Using "interval" here could cause minor confusion since it is a valid core data type but not accepted here.

psql --set=WATCH_INTERVAL='10m' postgres
psql: error: invalid value "10m" for "WATCH_INTERVAL"

select '10m'::interval;
 interval
----------
 00:10:00

How about:

+ "    if set to a number, overrides the default two second \\watch interval\n"

I do like the consistency of "if set" even though most of the others are booleans.

David J.

pgsql-hackers by date:

Previous
From: Chapman Flack
Date:
Subject: Re: FmgrInfo allocation patterns (and PL handling as staged programming)
Next
From: Greg Sabino Mullane
Date:
Subject: Re: Logging which local address was connected to in log_line_prefix