Re: FmgrInfo allocation patterns (and PL handling as staged programming) - Mailing list pgsql-hackers

From Chapman Flack
Subject Re: FmgrInfo allocation patterns (and PL handling as staged programming)
Date
Msg-id 67F31F20.6090706@acm.org
Whole thread Raw
In response to Re: FmgrInfo allocation patterns (and PL handling as staged programming)  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: FmgrInfo allocation patterns (and PL handling as staged programming)
List pgsql-hackers
On 04/06/25 20:01, Tom Lane wrote:
> Looking more closely at ProcedureCreate(), it makes a dependency
> if a transform *exists* for the argument or result type, whether
> a TRANSFORM clause is present or not.  Surely this is completely
> bogus?  We should be depending on the OIDs mentioned in protrftypes,

I think that's it. I tested by creating a function like

create function foo() returns text transform for type circle

that is, with the transform type not appearing as an argument or
return type.

As far as I know, that's still a cromulent usage, as I could be saying
I want the function to apply that transform to circles it uses or retrieves
in queries it makes.

But if the dependency is being created based on argument/return types
and not on protrftypes, that will slip right through the cracks.

Regards,
-Chap



pgsql-hackers by date:

Previous
From: Fujii Masao
Date:
Subject: Re: Use XLOG_CONTROL_FILE macro everywhere?
Next
From: "David G. Johnston"
Date:
Subject: Re: Possibly hard-to-read message