Re: Memory leak in XLOG reader facility when decoding records (caused by WAL refactoring) - Mailing list pgsql-bugs

From Sushant Sinha
Subject Re: Memory leak in XLOG reader facility when decoding records (caused by WAL refactoring)
Date
Msg-id CAK=sinWiyk_VpXKiuijdLfJVo750Df5iMWH-tmrWSicCUT7R5Q@mail.gmail.com
Whole thread Raw
In response to Re: Memory leak in XLOG reader facility when decoding records (caused by WAL refactoring)  (Michael Paquier <michael.paquier@gmail.com>)
Responses Re: Memory leak in XLOG reader facility when decoding records (caused by WAL refactoring)
List pgsql-bugs
Can this be a reason behind this issue that I was facing? High disk writes
after upgrade from 9.4.3 to 9.4.4.

http://www.postgresql.org/message-id/CAK=sinUouE8XVxBc4d6bcgM5OJVy7R-B9HF_7BQZs6LR87_Ung@mail.gmail.com

On Tue, Jul 28, 2015 at 12:00 PM, Michael Paquier <michael.paquier@gmail.com
> wrote:

> On Tue, Jul 28, 2015 at 3:11 PM, Heikki Linnakangas wrote:
> > On 07/28/2015 02:54 AM, Michael Paquier wrote:
> >> The problem is that state->max_block_id gets reset to -1 each time a
> >> new record is read via ResetDecoder. Hence if we decode a record that
> >> has block data and then if a second record that does not contain block
> >> data is decoded, we will leak if XLogReaderFree is called because no
> >> attempts will be made to pfree what has been allocated. Per se the
> >> patch attached.
> >
> >
> > Ok, committed. I hope we got it right this time..
>
> Thanks! There is nothing more on radar now, so I am closing the issue
> on the open item list.
> --
> Michael
>
>
> --
> Sent via pgsql-bugs mailing list (pgsql-bugs@postgresql.org)
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgsql-bugs
>

pgsql-bugs by date:

Previous
From: Michael Paquier
Date:
Subject: Re: Memory leak in XLOG reader facility when decoding records (caused by WAL refactoring)
Next
From: Michael Paquier
Date:
Subject: Re: Memory leak in XLOG reader facility when decoding records (caused by WAL refactoring)