Re: Memory leak in XLOG reader facility when decoding records (caused by WAL refactoring) - Mailing list pgsql-bugs

From Michael Paquier
Subject Re: Memory leak in XLOG reader facility when decoding records (caused by WAL refactoring)
Date
Msg-id CAB7nPqR8JTZ0n--UN9zAqf2CdNHJspLgZS=aRS_Cjyj-xfA4Ww@mail.gmail.com
Whole thread Raw
In response to Re: Memory leak in XLOG reader facility when decoding records (caused by WAL refactoring)  (Heikki Linnakangas <hlinnaka@iki.fi>)
Responses Re: Memory leak in XLOG reader facility when decoding records (caused by WAL refactoring)
List pgsql-bugs
On Tue, Jul 28, 2015 at 3:11 PM, Heikki Linnakangas wrote:
> On 07/28/2015 02:54 AM, Michael Paquier wrote:
>> The problem is that state->max_block_id gets reset to -1 each time a
>> new record is read via ResetDecoder. Hence if we decode a record that
>> has block data and then if a second record that does not contain block
>> data is decoded, we will leak if XLogReaderFree is called because no
>> attempts will be made to pfree what has been allocated. Per se the
>> patch attached.
>
>
> Ok, committed. I hope we got it right this time..

Thanks! There is nothing more on radar now, so I am closing the issue
on the open item list.
--
Michael

pgsql-bugs by date:

Previous
From: Heikki Linnakangas
Date:
Subject: Re: Memory leak in XLOG reader facility when decoding records (caused by WAL refactoring)
Next
From: Sushant Sinha
Date:
Subject: Re: Memory leak in XLOG reader facility when decoding records (caused by WAL refactoring)