This new version of the patch compiles well with the HEAD and resolved the following issues .
> > 2) I think the code in RI_Initial_Check() would be cleaner if you used > > "CROSS JOIN LATERAL unnest(col)" rather than having unnest() in the target > > list. This way you would not need to rename all columns and the code paths > > for the array case could look more like the code path for the normal case.
The RI query has been re-factored thanks to Andreas.
== The @>> operator
A previous version of your patch added the "anyelement <<@ anyarray" operator to avoid having to build arrays, but that part was reverted due to a bug.
I am not expert on the gin code, but as far as I can tell it would be relatively simple to fix that bug. Just allocate an array of Datums of length one where you put the element you are searching for (or maybe a copy of it).
The @>> is now restored and functioning correctly, all issues with contrib libraries has been resolved
> > 1) MATCH FULL does not seem to care about NULLS in arrays. In the example > > below I expected both inserts into the referring table to fail. > > > > CREATE TABLE t (x int, y int, PRIMARY KEY (x, y)); > > CREATE TABLE fk (x int, ys int[], FOREIGN KEY (x, EACH ELEMENT OF ys) REFERENCES t MATCH FULL); > > INSERT INTO t VALUES (10, 1); > > INSERT INTO fk VALUES (10, '{1,NULL}'); > > INSERT INTO fk VALUES (NULL, '{1}');
We agreed that MATCH FULL can wait for a future patch. It's not needed for now
We really need a review so the patch can pass in this commitfest.
