Re: [HACKERS] GSoC 2017: Foreign Key Arrays - Mailing list pgsql-hackers

From Mark Rofail
Subject Re: [HACKERS] GSoC 2017: Foreign Key Arrays
Date
Msg-id CAJvoCuty7ZT6KrUxP=b3ownM7AoGqCOhU+vMzwv-ZdqkDPuwYA@mail.gmail.com
Whole thread Raw
In response to Re: [HACKERS] GSoC 2017: Foreign Key Arrays  (Andreas Karlsson <andreas@proxel.se>)
Responses Re: [HACKERS] GSoC 2017: Foreign Key Arrays
List pgsql-hackers
Thank you for the review.

Please find the new patch here, with your comments taken into consideration.

However, the following comment "Related to the above: I am not sure if it is a good idea to make ELEMENT a reserved word in column definitions. What if the SQL standard wants to use it for something?
I think I prefer (EACH ELEMENT OF xs) over (ELEMENT xs) given how the former is more in what I feel is the spirit of SQL. And if so we should match it as "xs integer[] EACH ELEMENT REFERENCES t1 (x)", assuming we want that syntax." is outside my area of expertise. The original authors should take a look at it (Tom Lane and Marco). They had a whole discussion on the matter, here. https://www.postgresql.org/message-id/6256.1350613614%40sss.pgh.pa.us

Best Regards,
Mark Rofail
Attachment

pgsql-hackers by date:

Previous
From: Peter Geoghegan
Date:
Subject: Re: [HACKERS] ICU locales and text/char(n) SortSupport on Windows
Next
From: Tomas Vondra
Date:
Subject: Re: [HACKERS] VACUUM and ANALYZE disagreeing on what reltuples means