Postgres Pro
Downloads
Home   >   mailing lists

Re: [HACKERS] GSoC 2017: Foreign Key Arrays - Mailing list pgsql-hackers

From Mark Rofail
Subject Re: [HACKERS] GSoC 2017: Foreign Key Arrays
Date
Msg-id CAJvoCusQzaWE-WwsagWtHFuX7H5sScgXO2bNXY1UYOx9F13zLA@mail.gmail.com
Whole thread Raw
In response to Re: [HACKERS] GSoC 2017: Foreign Key Arrays  (Zhihong Yu <zyu@yugabyte.com>)
List pgsql-hackers
Tree view
Hello Zhihong,

Thank you for your review, please continue giving feedback, your help is appreciated!

I think the ARR_HASNULL(arr) condition is not reflected in the error message.
 Added to v16

I don't see CASCADE in the if condition that follows the above comment.
  Added to v16

The code would be FKCONSTR_REF_EACH_ELEMENT and FKCONSTR_REF_PLAIN. I think you can mention them in the comment.
 Added to v16

Changelog (Main Patch):
- v16 (compatible with current master 2021-01-28 commit 6f5c8a8ec23f8ab00da4d2b77bfc8af2a578c4d3)
    * added customised message for ARR_HASNULL(arr)
    * removed DELETE CASCADE comment
    * added FKCONSTR_REF_EACH_ELEMENT and FKCONSTR_REF_PLAIN comment
    * added is array check on FK creation
    * total rewrite of "generate_operator_clause" edit (shift to <@ instead of @> for less code)

Changelog (ContainsElem): 
- v2 (comaptible with v16):
   * made compatible with Main Patch v16

The next step is performance benchmarking, will report the results soon.

/Mark
Attachment

pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: [PATCH] postgres_fdw connection caching - cause remote sessions linger till the local session exit
Next
From: Mark Rofail
Date:
Subject: Re: [HACKERS] GSoC 2017: Foreign Key Arrays