Re: [BUGS] BUG #9652: inet types don't support min/max - Mailing list pgsql-hackers

From Haribabu Kommi
Subject Re: [BUGS] BUG #9652: inet types don't support min/max
Date
Msg-id CAJrrPGfL-xHndQCozWP42K9uHPpO_GGNgP-g2X1D4FjhY6DVdg@mail.gmail.com
Whole thread Raw
In response to Re: [BUGS] BUG #9652: inet types don't support min/max  (Asif Naeem <anaeem.it@gmail.com>)
Responses Re: [BUGS] BUG #9652: inet types don't support min/max  (Amit Kapila <amit.kapila16@gmail.com>)
Re: [BUGS] BUG #9652: inet types don't support min/max  (Asif Naeem <anaeem.it@gmail.com>)
List pgsql-hackers
On Mon, Jul 7, 2014 at 6:59 PM, Asif Naeem <anaeem.it@gmail.com> wrote:
> Hi Haribabu,
>
> Thank you for sharing the patch. I have spent some time to review the
> changes. Overall patch looks good to me, make check and manual testing seems
> run fine with it. There seems no related doc/sgml changes ?. Patch added
> network_smaller() and network_greater() functions but in PG source code,
> general practice seems to be to use “smaller" and “larger” as related
> function name postfix e.g. timestamp_smaller()/timestamp_larger(),
> interval_smaller/interval_larger(), cashsmaller()/cashlarger() etc. Thanks.

Thanks for reviewing the patch.

I corrected the function names as smaller and larger.
and also added documentation changes.

Updated patch attached in the mail.

Regards,
Hari Babu
Fujitsu Australia

Attachment

pgsql-hackers by date:

Previous
From: "MauMau"
Date:
Subject: Re: [bug fix or improvement?] Correctly place DLLs for ECPG apps in bin folder
Next
From: M Tarkeshwar Rao
Date:
Subject: FW: [postgres-discuss] Insert query hangs