Postgres Pro
Downloads
Home   >   mailing lists

Re: [BUGS] BUG #9652: inet types don't support min/max - Mailing list pgsql-hackers

From Asif Naeem
Subject Re: [BUGS] BUG #9652: inet types don't support min/max
Date
Msg-id CAEB4t-M49wLVgU7RRbqW1Pd+JG=Qj4qPeeB7MZex8OygG1GyfA@mail.gmail.com
Whole thread Raw
In response to Re: [BUGS] BUG #9652: inet types don't support min/max  (Asif Naeem <anaeem.it@gmail.com>)
Responses Re: [BUGS] BUG #9652: inet types don't support min/max  (Haribabu Kommi <kommi.haribabu@gmail.com>)
List pgsql-hackers
Tree view
Hi Haribabu,

Thank you for sharing the patch. I have spent some time to review the changes. Overall patch looks good to me, make check and manual testing seems run fine with it. There seems no related doc/sgml changes ?. Patch added network_smaller() and network_greater() functions but in PG source code, general practice seems to be to use “smaller" and “larger” as related function name postfix e.g. timestamp_smaller()/timestamp_larger(), interval_smaller/interval_larger(), cashsmaller()/cashlarger() etc. Thanks.

Regards,
Muhammad Asif Naeem


On Mon, Jul 7, 2014 at 1:56 PM, Asif Naeem <anaeem.it@gmail.com> wrote:
On Mon, Jun 30, 2014 at 4:45 PM, Abhijit Menon-Sen <ams@2ndquadrant.com> wrote:
At 2014-06-30 16:35:45 +0500, anaeem.it@gmail.com wrote:
>
> pc1dotnetpk:postgresql asif$ patch -p0 <
> > ~/core/min_max_support_for_inet_datatypes/inet_agg_v4.patch
> > can't find file to patch at input line 3
> > Perhaps you used the wrong -p or --strip option?
> > The text leading up to this was:
> > --------------------------
> > |*** a/src/backend/utils/adt/network.c
> > |--- b/src/backend/utils/adt/network.c
> > --------------------------

You need to use patch -p1, to strip off the "a"/"b" prefix.

Thank you Abhijit, It worked.
 

-- Abhijit


pgsql-hackers by date:

Previous
From: Asif Naeem
Date:
Subject: Re: [BUGS] BUG #9652: inet types don't support min/max
Next
From: Andres Freund
Date:
Subject: Re: pg_xlogdump --stats