Postgres Pro
Downloads
Home   >   mailing lists

Re: [HACKERS] ANALYZE command progress checker - Mailing list pgsql-hackers

From Haribabu Kommi
Subject Re: [HACKERS] ANALYZE command progress checker
Date
Msg-id CAJrrPGcnc9Fhv+Q-7XHHniUxPZfoMr1uq9cCH83Nao6OSbhxeQ@mail.gmail.com
Whole thread Raw
In response to Re: [HACKERS] ANALYZE command progress checker  (vinayak <Pokale_Vinayak_q3@lab.ntt.co.jp>)
Responses Re: [HACKERS] ANALYZE command progress checker  (vinayak <Pokale_Vinayak_q3@lab.ntt.co.jp>)
List pgsql-hackers
Tree view


On Tue, Mar 21, 2017 at 3:41 PM, vinayak <Pokale_Vinayak_q3@lab.ntt.co.jp> wrote:
Thank you for testing the patch on Windows platform.


Thanks for the updated patch.

It works good for a normal relation.  But for a relation that contains child tables,
the PROGRESS_ANALYZE_NUM_ROWS_SAMPLED produces wrong results.

How about adding another phase called PROGRESS_ANALYZE_PHASE_COLLECT_INHERIT_SAMPLE_ROWS
and set this phase only when it is an inheritance analyze operation. And adding
some explanation of ROWS_SAMPLED phase about inheritance tables
how these sampled rows are calculated will provide good analyze progress of
relation that contains child relations also.
 
Regards,
Hari Babu
Fujitsu Australia

pgsql-hackers by date:

Previous
From: Dilip Kumar
Date:
Subject: Re: [HACKERS] Problem in Parallel Bitmap Heap Scan?
Next
From: Emre Hasegeli
Date:
Subject: Re: [HACKERS] BRIN cost estimate