Re: Conflict detection for update_deleted in logical replication - Mailing list pgsql-hackers

On Thu, Jun 12, 2025 at 11:34 AM Zhijie Hou (Fujitsu)
<houzj.fnst@fujitsu.com> wrote:
>
>
> Here is the V35 patch set which includes the following changes:
>

Thank You for the patches. Few comments:

1)
Since now we create slot for rci enabled subscription, it will require
wal_level >= replica even on subscribers. We shall mention this in the
docs.

2)
postgres=# alter subscription sub3 set (retain_conflict_info=true);
NOTICE:  deleted rows will continue to accumulate for detecting
conflicts until the subscription is enabled
ALTER SUBSCRIPTION

postgres=# alter subscription sub3 disable;
WARNING:  deleted rows to detect conflicts would not be removed until
the subscription is enabled
HINT:  Consider setting retain_conflict_info to false.

I feel we shall have the same message in both the cases as we are
trying to convey the exact same thing concerning deleted rows
accumulation..

thanks
Shveta