Re: Add SPLIT PARTITION/MERGE PARTITIONS commands - Mailing list pgsql-hackers

From jian he
Subject Re: Add SPLIT PARTITION/MERGE PARTITIONS commands
Date
Msg-id CACJufxEvPf7__DRJ8HRrxBk=iNN+dDXrQTTj=pB5N2=ZvnC_BA@mail.gmail.com
Whole thread Raw
In response to Re: Add SPLIT PARTITION/MERGE PARTITIONS commands  (jian he <jian.universality@gmail.com>)
List pgsql-hackers
hi.
one more minor issue.

+ * defaultPart: true if one of split partitions is DEFAULT
+ * pstate: pointer to ParseState struct for determining error position
+ */
+static void
+check_two_partitions_bounds_range(Relation parent,
+  RangeVar *first_name,
+  PartitionBoundSpec *first_bound,
+  RangeVar *second_name,
+  PartitionBoundSpec *second_bound,
+  bool defaultPart,
+  ParseState *pstate)

v43-0001 doesn't have the SPLIT PARTITION feature.
maybe we need to remove the argument (bool defaultPart)
from check_two_partitions_bounds_range, aslo remove the comments.
then we can add it on 0002 SPLIT PARTITION patch.



pgsql-hackers by date:

Previous
From: shveta malik
Date:
Subject: Re: Conflict detection for update_deleted in logical replication
Next
From: Konstantin Knizhnik
Date:
Subject: Re: Non-reproducible AIO failure