Re: [Proposal] Global temporary tables - Mailing list pgsql-hackers

From Andrew Bille
Subject Re: [Proposal] Global temporary tables
Date
Msg-id CAJnzarwfCozjDm74Ps-tQO_g-2CZ-ObuDP5k8eCDRsaFaNdg2w@mail.gmail.com
Whole thread Raw
In response to Re: [Proposal] Global temporary tables  (wenjing <wjzeng2012@gmail.com>)
Responses Re: [Proposal] Global temporary tables
List pgsql-hackers
Hi!

I could not detect crashes with your last patch, so I think the patch is ready for a review.
Please, also consider fixing error messages, as existing ones don't follow message writing guidelines. https://www.postgresql.org/docs/14/error-style-guide.html

Regards, Andrew

On Thu, Dec 23, 2021 at 7:36 PM wenjing <wjzeng2012@gmail.com> wrote:


Andrew Bille <andrewbille@gmail.com> 于2021年12月21日周二 14:00写道:
Hi!
Thanks for new patches.
Yet another crash reproduced on master with v63 patches:

CREATE TABLESPACE ts LOCATION '/tmp/ts';
CREATE GLOBAL TEMP TABLE tbl (num1 bigint);
INSERT INTO tbl (num1) values (1);
CREATE INDEX tbl_idx ON tbl (num1);
REINDEX (TABLESPACE ts) TABLE tbl;
This is a feature made in PG14 that supports reindex change tablespaces. 
Thank you for pointing that out and I fixed it in v64.
Waiting for your feedback.

pgsql-hackers by date:

Previous
From: Andrey Borodin
Date:
Subject: Re: reporting TID/table with corruption error
Next
From: Thomas Munro
Date:
Subject: Re: Why is src/test/modules/committs/t/002_standby.pl flaky?