Hi!I could not detect crashes with your last patch, so I think the patch is ready for a review.Please, also consider fixing error messages, as existing ones don't follow message writing guidelines. https://www.postgresql.org/docs/14/error-style-guide.html
Regards, AndrewOn Thu, Dec 23, 2021 at 7:36 PM wenjing <wjzeng2012@gmail.com> wrote:Andrew Bille <andrewbille@gmail.com> 于2021年12月21日周二 14:00写道:Hi!Thanks for new patches.Yet another crash reproduced on master with v63 patches:CREATE TABLESPACE ts LOCATION '/tmp/ts';CREATE GLOBAL TEMP TABLE tbl (num1 bigint);INSERT INTO tbl (num1) values (1);CREATE INDEX tbl_idx ON tbl (num1);REINDEX (TABLESPACE ts) TABLE tbl;This is a feature made in PG14 that supports reindex change tablespaces. Thank you for pointing that out and I fixed it in v64.Waiting for your feedback.
Andrew Bille <andrewbille@gmail.com> 于2021年12月21日周二 14:00写道:Hi!Thanks for new patches.Yet another crash reproduced on master with v63 patches:CREATE TABLESPACE ts LOCATION '/tmp/ts';CREATE GLOBAL TEMP TABLE tbl (num1 bigint);INSERT INTO tbl (num1) values (1);CREATE INDEX tbl_idx ON tbl (num1);REINDEX (TABLESPACE ts) TABLE tbl;This is a feature made in PG14 that supports reindex change tablespaces. Thank you for pointing that out and I fixed it in v64.Waiting for your feedback.
Hi!Thanks for new patches.Yet another crash reproduced on master with v63 patches:CREATE TABLESPACE ts LOCATION '/tmp/ts';CREATE GLOBAL TEMP TABLE tbl (num1 bigint);INSERT INTO tbl (num1) values (1);CREATE INDEX tbl_idx ON tbl (num1);REINDEX (TABLESPACE ts) TABLE tbl;
pgsql-hackers by date:
Соглашаюсь с условиями обработки персональных данных