Use outerPlanState() consistently in executor code - Mailing list pgsql-hackers

From Qingqing Zhou
Subject Use outerPlanState() consistently in executor code
Date
Msg-id CAJjS0u3nEZvUUJN1q8b1cxd-OoJ09F=EU8WKLNq-_CFbKo9X6A@mail.gmail.com
Whole thread Raw
Responses Re: Use outerPlanState() consistently in executor code
List pgsql-hackers
In executor context, outerPlanState(node) is the same as
node->ss.ps.lefttree. We follow this in most places except a few. This
patch clean up the outliers and might save us a few instructions by
removing indirection.

Most of changes are trivial. Except I take out an outerPlan nullable
check in grouping iterator - as a it surely has a left child.

I noticed that we mixed use "node" for plan node and plan state. While
changing it can make code clear, but back patching could be terrible.


Regards,
Qingqing

Attachment

pgsql-hackers by date:

Previous
From: Alvaro Herrera
Date:
Subject: Re: [COMMITTERS] pgsql: Move pg_upgrade from contrib/ to src/bin/
Next
From: Simon Riggs
Date:
Subject: Re: Turning off HOT/Cleanup sometimes