Re: Skipping logical replication transactions on subscriber side - Mailing list pgsql-hackers

On Mon, Aug 16, 2021 at 5:54 PM houzj.fnst@fujitsu.com
<houzj.fnst@fujitsu.com> wrote:
>
> Here is another comment:
>
> +char *
> +logicalrep_message_type(LogicalRepMsgType action)
> +{
> ...
> +               case LOGICAL_REP_MSG_STREAM_END:
> +                       return "STREAM END";
> ...
>
> I think most the existing code use "STREAM STOP" to describe the
> LOGICAL_REP_MSG_STREAM_END message, is it better to return "STREAM STOP" in
> function logicalrep_message_type() too ?
>

+1
I think you're right, it should be "STREAM STOP" in that case.


Regards,
Greg Nancarrow
Fujitsu Australia