Postgres Pro
Downloads
Home   >   mailing lists

Executor code - found an instance of a WHILE that should just be an IF - Mailing list pgsql-hackers

From Greg Nancarrow
Subject Executor code - found an instance of a WHILE that should just be an IF
Date
Msg-id CAJcOf-d7T1q0az-D8evWXnsuBZjigT04WkV5hCAOEJQZRWy28w@mail.gmail.com
Whole thread Raw
Responses Re: Executor code - found an instance of a WHILE that should just be an IF
List pgsql-hackers
Tree view 
Hi,

During debugging I noticed some code in ExecResult() where a WHILE
loop is being used with an unconditional RETURN at the end of the
block (which is intentional, looking at the history of changes), but
now there's no actual use of the loop in any way. The code should
probably be changed to just use IF for clarity.
I've attached a patch.

Regards,
Greg Nancarrow
Fujitsu Australia
Attachment

pgsql-hackers by date:

Previous
From: Peter Smith
Date:
Subject: Re: GetSubscriptionRelations declares too many scan keys
Next
From: Julien Rouhaud
Date:
Subject: Re: GetSubscriptionRelations declares too many scan keys