Re: wrapping in extended mode doesn't work well with default pager - Mailing list pgsql-hackers

From Sergey Muraviov
Subject Re: wrapping in extended mode doesn't work well with default pager
Date
Msg-id CAJTaR30koAru2tucYiAZ=JjFFi8TZ0K7dhfSY-y7bsFj347zdg@mail.gmail.com
Whole thread Raw
In response to Re: wrapping in extended mode doesn't work well with default pager  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
Hi.

I tried to take into account all of yours comments.

PS
This patch prints newline indicators in aligned mode, but this functionality can be easily disabled.

PPS
I'm on vacations now and don't read mail everyday.


2014-06-12 6:16 GMT+04:00 Tom Lane <tgl@sss.pgh.pa.us>:
Noah Misch <noah@leadboat.com> writes:
> Based on the commit message and procedural history, I thought commit 6513633
> was changing behavior solely for the combination of "\pset expanded" and
> "\pset format wrapped".  Peter's and my test cases show that it also changed
> behavior for "\pset expanded" alone.  That's a bug, unless someone sees to
> argue that the new "\pset expanded" behavior is a desirable improvement in
> spite of its origin as an accident.  Altering an entrenched psql output format
> is a big deal.

TBH I'm wondering if we shouldn't just revert that patch (and the
subsequent fix attempts).  It was not a major feature and I'm thinking
we have better things to do right now than try to fix the multiple
logic holes it evidently has.  The author's certainly welcome to try
again with a more carefully thought-through patch for 9.5.

                        regards, tom lane



--
Best regards,
Sergey Muraviov
Attachment

pgsql-hackers by date:

Previous
From: Jochem van Dieten
Date:
Subject: Re: "RETURNING PRIMARY KEY" syntax extension
Next
From: Ian Barwick
Date:
Subject: Re: "RETURNING PRIMARY KEY" syntax extension