On Mon, Oct 24, 2022 at 11:02 AM Simon Riggs
<simon.riggs@enterprisedb.com> wrote:
>
> On Sun, 16 Oct 2022 at 02:08, Bruce Momjian <bruce@momjian.us> wrote:
> >
> > On Fri, Oct 14, 2022 at 05:46:55PM -0400, Robert Treat wrote:
> > > On Fri, Oct 14, 2022 at 3:51 PM Bruce Momjian <bruce@momjian.us> wrote:
> > > > Attached is the merged patch from all the great comments I received. I
> > > > have also rebuilt the docs with the updated patch:
> > > >
> > > > https://momjian.us/tmp/pgsql/
> > > >
> > >
> > > + <command>RELEASE SAVEPOINT</command> also subcommits and destroys
> > > + all savepoints that were established after the named savepoint was
> > > + established. This means that any subtransactions of the named savepoint
> > > + will also be subcommitted and destroyed.
> > >
> > > Wonder if we should be more explicit that data changes are preserved,
> > > not destroyed... something like:
> > > "This means that any changes within subtransactions of the named
> > > savepoint will be subcommitted and those subtransactions will be
> > > destroyed."
> >
> > Good point. I reread the section and there was just too much confusion
> > over subtransactions, partly because the behavior just doesn't map
> > easily to subtransaction. I therefore merged all three paragraphs into
> > one and tried to make the text saner; release_savepoint.sgml diff
> > attached, URL content updated.
>
> Just got around to reading this, thanks for changes.
>
> The rewording doesn't work for me. The use of the word "destroy" is
> very misleading, since the effect is to commit.
>
> So I think we must avoid use of the word destroy completely. Possible
> rewording:
>
> <command>RELEASE SAVEPOINT</command> will subcommit the subtransaction
> established by the named savepoint, releasing any resources held by
> it. If there were any subtransactions created by the named savepoint,
> these will also be subcommitted.
>
I think it should be "If there were any subtransactions of the named
savepoint, these will also be subcommitted", but otherwise I think
this wording should work.
Robert Treat
https://xzilla.net
