Re: TABLESAMPLE patch - Mailing list pgsql-hackers

From Jaime Casanova
Subject Re: TABLESAMPLE patch
Date
Msg-id CAJKUy5h9oGcuMU8AZ-dmPSru+RQARY_0Y6D8N9=xS8F6_EquBQ@mail.gmail.com
Whole thread Raw
In response to TABLESAMPLE patch  (Petr Jelinek <petr@2ndquadrant.com>)
Responses Re: TABLESAMPLE patch
List pgsql-hackers
On Wed, Dec 10, 2014 at 6:24 PM, Petr Jelinek <petr@2ndquadrant.com> wrote:
> Hello,
>
> Attached is a basic implementation of TABLESAMPLE clause. It's SQL standard
> clause and couple of people tried to submit it before so I think I don't
> need to explain in length what it does - basically returns "random" sample
> of a table using a specified sampling method.
>

Tablesample, yay!

Sadly when the jsonb functions patch was committed a few oids where
used, so you should update the ones you are using. at least to make
the patch easier for testing.

The test added for this failed, attached is the diff. i didn't looked
up why it failed

Finally, i created a view with a tablesample clause. i used the view
and the tablesample worked, then dumped and restored and the
tablesample clause went away... actually pg_get_viewdef() didn't see
it at all.

will look at the patch more close tomorrow when my brain wake up ;)

--
Jaime Casanova         www.2ndQuadrant.com
Professional PostgreSQL: Soporte 24x7 y capacitación
Phone: +593 4 5107566         Cell: +593 987171157

Attachment

pgsql-hackers by date:

Previous
From: David Rowley
Date:
Subject: Re: Commitfest problems
Next
From: Craig Ringer
Date:
Subject: Re: Commitfest problems