Hello Fahar,File, pgagent-4.0.0-1-linux-x64.run is uploaded @ https://uploads.enterprisedb.com/download.php?file=bd89aec08d73ceae21cf560c391598f6On Tue, Jun 5, 2018 at 3:10 PM, Dave Page <dpage@pgadmin.org> wrote:Thanks, committed with those changes.Paresh; can you please create some pgAgent 4.0 installers (PG not EPAS Bitrock installers) from git head for Fahar to test?Once he's happy with them, I'll tag and build the community packages.Thanks!On Tue, Jun 5, 2018 at 5:07 AM, Ashesh Vashi <ashesh.vashi@enterprisedb.com> wrote:On Mon, Jun 4, 2018 at 10:04 PM, Dave Page <dpage@pgadmin.org> wrote:HiCan you review the attached please Ashesh?Hi Dave,Due to the wrong pattern in '.gitignore', it was ignoring the new file 'sql/pgagent--3.4--4.0.sql'.We should ignore only the '*.sql' in the root directory.Something like this.$ git diff .gitignorediff --git a/.gitignore b/.gitignoreindex 9883354..40fe7a9 100644--- a/.gitignore+++ b/.gitignore@@ -6,7 +6,12 @@ CPackSourceConfig.cmake Makefile cmake_install.cmake install_manifest.txt-pgagent+# Ignore 'pgagent' & 'pgagent.control' in root directory only.+/pgagent+!/*/pgagent pgagent.control+!/*/pgagent.control *.log-*.sql+# Ignore '*.sql' files in root directory only.+/*.sql+!/*/*.sqlAnd, I am getting the following warning applying the patch.$ git apply ~/Downloads/pgagent-4.0-update.diff/Users/asheshvashi/Downloads/pgagent-4.0-update.diff:320: trailing whitespace.//warning: 1 line adds whitespace errors.Otherwise - it looks good to me.--Thanks & Regards,Ashesh VashiEnterpriseDB INDIA: Enterprise PostgreSQL Companyhttp://www.linkedin.com/in/asheshvashi Thanks.-- Dave PageBlog: http://pgsnake.blogspot.comTwitter: @pgsnakeEnterpriseDB UK: http://www.enterprisedb.comThe Enterprise PostgreSQL Company-- Dave PageBlog: http://pgsnake.blogspot.comTwitter: @pgsnakeEnterpriseDB UK: http://www.enterprisedb.comThe Enterprise PostgreSQL Company-- Thanks & RegardsParesh MorePune, India.Cell : +919922000564 | www.enterprisedb.com
Thanks, committed with those changes.Paresh; can you please create some pgAgent 4.0 installers (PG not EPAS Bitrock installers) from git head for Fahar to test?Once he's happy with them, I'll tag and build the community packages.Thanks!On Tue, Jun 5, 2018 at 5:07 AM, Ashesh Vashi <ashesh.vashi@enterprisedb.com> wrote:On Mon, Jun 4, 2018 at 10:04 PM, Dave Page <dpage@pgadmin.org> wrote:HiCan you review the attached please Ashesh?Hi Dave,Due to the wrong pattern in '.gitignore', it was ignoring the new file 'sql/pgagent--3.4--4.0.sql'.We should ignore only the '*.sql' in the root directory.Something like this.$ git diff .gitignorediff --git a/.gitignore b/.gitignoreindex 9883354..40fe7a9 100644--- a/.gitignore+++ b/.gitignore@@ -6,7 +6,12 @@ CPackSourceConfig.cmake Makefile cmake_install.cmake install_manifest.txt-pgagent+# Ignore 'pgagent' & 'pgagent.control' in root directory only.+/pgagent+!/*/pgagent pgagent.control+!/*/pgagent.control *.log-*.sql+# Ignore '*.sql' files in root directory only.+/*.sql+!/*/*.sqlAnd, I am getting the following warning applying the patch.$ git apply ~/Downloads/pgagent-4.0-update.diff/Users/asheshvashi/Downloads/pgagent-4.0-update.diff:320: trailing whitespace.//warning: 1 line adds whitespace errors.Otherwise - it looks good to me.--Thanks & Regards,Ashesh VashiEnterpriseDB INDIA: Enterprise PostgreSQL Companyhttp://www.linkedin.com/in/asheshvashi Thanks.-- Dave PageBlog: http://pgsnake.blogspot.comTwitter: @pgsnakeEnterpriseDB UK: http://www.enterprisedb.comThe Enterprise PostgreSQL Company-- Dave PageBlog: http://pgsnake.blogspot.comTwitter: @pgsnakeEnterpriseDB UK: http://www.enterprisedb.comThe Enterprise PostgreSQL Company
On Mon, Jun 4, 2018 at 10:04 PM, Dave Page <dpage@pgadmin.org> wrote:HiCan you review the attached please Ashesh?Hi Dave,Due to the wrong pattern in '.gitignore', it was ignoring the new file 'sql/pgagent--3.4--4.0.sql'.We should ignore only the '*.sql' in the root directory.Something like this.$ git diff .gitignorediff --git a/.gitignore b/.gitignoreindex 9883354..40fe7a9 100644--- a/.gitignore+++ b/.gitignore@@ -6,7 +6,12 @@ CPackSourceConfig.cmake Makefile cmake_install.cmake install_manifest.txt-pgagent+# Ignore 'pgagent' & 'pgagent.control' in root directory only.+/pgagent+!/*/pgagent pgagent.control+!/*/pgagent.control *.log-*.sql+# Ignore '*.sql' files in root directory only.+/*.sql+!/*/*.sqlAnd, I am getting the following warning applying the patch.$ git apply ~/Downloads/pgagent-4.0-update.diff/Users/asheshvashi/Downloads/pgagent-4.0-update.diff:320: trailing whitespace.//warning: 1 line adds whitespace errors.Otherwise - it looks good to me.--Thanks & Regards,Ashesh VashiEnterpriseDB INDIA: Enterprise PostgreSQL Companyhttp://www.linkedin.com/in/asheshvashi Thanks.-- Dave PageBlog: http://pgsnake.blogspot.comTwitter: @pgsnakeEnterpriseDB UK: http://www.enterprisedb.comThe Enterprise PostgreSQL Company
HiCan you review the attached please Ashesh?
$ git diff .gitignorediff --git a/.gitignore b/.gitignoreindex 9883354..40fe7a9 100644--- a/.gitignore+++ b/.gitignore@@ -6,7 +6,12 @@ CPackSourceConfig.cmake Makefile cmake_install.cmake install_manifest.txt-pgagent+# Ignore 'pgagent' & 'pgagent.control' in root directory only.+/pgagent+!/*/pgagent pgagent.control+!/*/pgagent.control *.log-*.sql+# Ignore '*.sql' files in root directory only.+/*.sql+!/*/*.sql
$ git apply ~/Downloads/pgagent-4.0-update.diff/Users/asheshvashi/Downloads/pgagent-4.0-update.diff:320: trailing whitespace.//warning: 1 line adds whitespace errors.
--
Thanks & Regards,Ashesh VashiEnterpriseDB INDIA: Enterprise PostgreSQL Company
http://www.linkedin.com/in/asheshvashi
Thanks.-- Dave PageBlog: http://pgsnake.blogspot.comTwitter: @pgsnakeEnterpriseDB UK: http://www.enterprisedb.comThe Enterprise PostgreSQL Company
Thanks & Regards
Paresh More
Pune, India.
pgadmin-hackers by date:
Соглашаюсь с условиями обработки персональных данных