Postgres Pro
Downloads
Home   >   mailing lists

Re: CREATE TABLE ( .. STORAGE ..) - Mailing list pgsql-hackers

From Aleksander Alekseev
Subject Re: CREATE TABLE ( .. STORAGE ..)
Date
Msg-id CAJ7c6TPsg6iUGZGaEGKi5vdG6VpEcLyZMbXTUQFnCNdi+Kd00Q@mail.gmail.com
Whole thread Raw
In response to Re: CREATE TABLE ( .. STORAGE ..)  (Peter Eisentraut <peter.eisentraut@enterprisedb.com>)
Responses Re: CREATE TABLE ( .. STORAGE ..)
List pgsql-hackers
Tree view 
Hi Peter,

> The "safety check: do not allow toasted storage modes unless column
> datatype is TOAST-aware" could be moved into GetAttributeStorage(), so
> it doesn't have to be repeated.  (Note that GetAttributeCompression()
> does similar checking.)

Good point. Fixed.

> ATExecSetStorage() currently doesn't do any such check, and your patch
> isn't adding one.  Is there a reason for that?

ATExecSetStorage() does this, but the check is a bit below [1]. In v7
I moved the check to GetAttributeStorage() as well.

[1] https://git.postgresql.org/gitweb/?p=postgresql.git;a=blob;f=src/backend/commands/tablecmds.c#l8312

-- 
Best regards,
Aleksander Alekseev
Attachment

pgsql-hackers by date:

Previous
From: vignesh C
Date:
Subject: Re: Handle infinite recursion in logical replication setup
Next
From: Nikita Malakhov
Date:
Subject: Re: [PATCH] Compression dictionaries for JSONB