Re: ExecTypeSetColNames is fundamentally broken - Mailing list pgsql-hackers

From Aleksander Alekseev
Subject Re: ExecTypeSetColNames is fundamentally broken
Date
Msg-id CAJ7c6TPfqfvB8AShZir1R054Wn7M5G4i_SgRM9K9-kADys8qEg@mail.gmail.com
Whole thread Raw
In response to Re: ExecTypeSetColNames is fundamentally broken  (Robert Haas <robertmhaas@gmail.com>)
Responses Re: ExecTypeSetColNames is fundamentally broken  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
Hi hackers,

> Anyone else have thoughts?

I came across this thread while looking for the patches that need review.

My understanding of the code is limited, but I can say that I don't
see anything particularly wrong with it. I can also confirm that it
fixes the problem reported by the user while passing the rest of the
tests.

I understand the concern expressed by Robert in respect of backward
compatibility. From the user's perspective, personally I would prefer
a fixed bug over backward compatibility. Especially if we consider the
fact that the current behaviour of cases like `select row_to_json(i)
from int8_tbl i(x,y)` is not necessarily the correct one, at least it
doesn't look right to me.

So unless anyone has strong objections against the proposed fix or can
propose a better patch, I would suggest merging it.

-- 
Best regards,
Aleksander Alekseev



pgsql-hackers by date:

Previous
From: Yura Sokolov
Date:
Subject: Declare PG_HAVE_8BYTE_SINGLE_COPY_ATOMICITY for aarch64
Next
From: Dagfinn Ilmari Mannsåker
Date:
Subject: Tab completion for SET TimeZone